Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up projects.json data #114

Merged
merged 3 commits into from
Jan 8, 2023
Merged

Clean up projects.json data #114

merged 3 commits into from
Jan 8, 2023

Conversation

michaelrambeau
Copy link
Member

@michaelrambeau michaelrambeau commented Jan 8, 2023

Goals

  • Reduce the amount of data stored in every projects.json file, to include only projects displayed in the page
  • Add tags included by the projects and use them in page static props instead of making a network request
  • Handle some feedback from Lighthouse about accessibiliy / SEO

Impact

It has a small impact on the assets generated as we send to client only the tags used by the projects included, instaad of all existing tags.

  • en.html: 439 => 435 kB
  • en.json: 104 => 99 kB

Lighthouse score on the branch

image

@vercel
Copy link

vercel bot commented Jan 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
javascript-risingstars ✅ Ready (Inspect) Visit Preview Jan 8, 2023 at 0:34AM (UTC)

@michaelrambeau michaelrambeau merged commit 6301bb3 into develop Jan 8, 2023
@michaelrambeau michaelrambeau deleted the improve-perf-step-2 branch January 27, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant