Improve pagination #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 25, 2019 06:29
Collection results which require pagination now include "pages", "next_page" and "prev_page". The later two only if there are next or previous pages. For example: https://10.0.19.168/REST/2.0/queues/all?per_page=5\&page=3 { "count" : 5, "pages" : 8, "page" : 3, "per_page" : 5, "prev_page" : "https://10.0.19.168/REST/2.0/queues/all?per_page=5&page=2", "next_page" : "https://10.0.19.168/REST/2.0/queues/all?per_page=5&page=4", "total" : 37, "items" : [ ... ] }
Because we haven't applied the limits to the query yet, the call to CountAll returns the total number of results. Therefore, using that to limit the number of available of pages is useless.
Conflicts: xt/pagination.t
|
This PR replaces #5 . |
bestpractical-mirror
pushed a commit
that referenced
this pull request
Mar 30, 2020
Collection results which require pagination now include "pages", "next_page" and "prev_page". The later two only if there are next or previous pages. For example: https://10.0.19.168/REST/2.0/queues/all?per_page=5\&page=3 { "count" : 5, "pages" : 8, "page" : 3, "per_page" : 5, "prev_page" : "https://10.0.19.168/REST/2.0/queues/all?per_page=5&page=2", "next_page" : "https://10.0.19.168/REST/2.0/queues/all?per_page=5&page=4", "total" : 37, "items" : [ ... ] } Don't limit the page param by a guess of the number of pages. Because we haven't applied the limits to the query yet, the call to CountAll returns the total number of results. Therefore, using that to limit the number of available of pages is useless. Based on public github PR #33
bestpractical-mirror
pushed a commit
that referenced
this pull request
Mar 30, 2020
Collection results which require pagination now include "pages", "next_page" and "prev_page". The later two only if there are next or previous pages. For example: https://10.0.19.168/REST/2.0/queues/all?per_page=5\&page=3 { "count" : 5, "pages" : 8, "page" : 3, "per_page" : 5, "prev_page" : "https://10.0.19.168/REST/2.0/queues/all?per_page=5&page=2", "next_page" : "https://10.0.19.168/REST/2.0/queues/all?per_page=5&page=4", "total" : 37, "items" : [ ... ] } Don't limit the page param by a guess of the number of pages. Because we haven't applied the limits to the query yet, the call to CountAll returns the total number of results. Therefore, using that to limit the number of available of pages is useless. Based on public github PR #33
|
Merged and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert total page count and previous/next links for plural collection results