-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Améliore et simplifie le footer #415
Conversation
Avoid diff on automatic package.json generation
Move from Bower to NPM for fonts management
<ul class="col-md-4 list-unstyled"> | ||
<li><span class="fa fa-fw fa-question-circle" aria-hidden="true"></span> <a ui-sref="a-propos">À propos</a></li> | ||
<li><span class="fa fa-fw fa-bullhorn" aria-hidden="true"></span> <a ui-sref="communication">Supports de communication</a></li> | ||
<li><span class="fa fa-fw fa-pencil" aria-hidden="true"></span> <a ui-sref="ameliorer">Améliorer ce site</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peut-être à mettre à l'impératif en échangeant avec « les aides pour les entreprises », pour regrouper toutes les actions suggérées ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ca me semble une bonne idée !
|
||
margin-top: 3em; | ||
padding-top: 2em; | ||
padding-bottom: 1em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pour que ce soit vraiment centré on peut mettre
padding-bottom: 2em
et rajouter une règlefooter ul { margin-bottom: 0; }
Penser à faire une release décrivant aussi #389 une fois cette PR intégrée. |
<link rel="stylesheet" href="/styles/homepage.css"> | ||
<link rel="stylesheet" href="/styles/individu-form.css"> | ||
<link rel="stylesheet" href="/styles/resources.css"> | ||
<link rel="stylesheet" href="/styles/logement.css"> | ||
<link rel="stylesheet" href="/styles/resultat.css"> | ||
<link rel="stylesheet" href="/js/lib/font-awesome/css/font-awesome.min.css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment est-ce que le fichier
font-awesome.min.css
, situé dans lesnode_mudules
, arrive à être servi sur cette route 🤔 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
<ul class="col-md-4 list-unstyled"> | ||
<li><span class="fa fa-fw fa-question-circle" aria-hidden="true"></span> <a ui-sref="a-propos">À propos</a></li> | ||
<li><span class="fa fa-fw fa-bullhorn" aria-hidden="true"></span> <a ui-sref="communication">Supports de communication</a></li> | ||
<li><span class="fa fa-fw fa-building-o" aria-hidden="true"></span> <a href="http://les-aides.fr">Les aides pour les entreprises</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pourquoi on référence ce lien ? Au cas où le visiteur se soit trompé d'adresse (mes
vs les
) ? Si c'est un indépendant qui cherche une aide pour son entreprise ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oui. Je ne sais pas à quel point il est pertinent de faire cette pub-là ici, mais on a eu deux prises de contact en ce sens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
C'est bien mieux qu'avant 🎉 ! |
Je crois qu'il y a une régression graphique sur la page enfants: @MattiSG, tu peux prendre ? |
flex
).font-awesome
à la 4.7.font-awesome
de Bower vers NPM.