Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajoute plus d'espace entre les éléments de la page utilisateurs classique. #596

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

niladic
Copy link
Collaborator

@niladic niladic commented Apr 7, 2020

Screen Shot 2020-04-07 at 19 42 27

@jdauphant jdauphant temporarily deployed to aplus-demo-task-fix-use-qrohbh April 7, 2020 18:08 Inactive
@niladic niladic merged commit 92efe3f into master Apr 14, 2020
@niladic niladic deleted the task/fix-user-list-design branch April 14, 2020 13:28
Copy link
Member

@jdauphant jdauphant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai oublié de valider la review ^^

</tfoot>
<tbody>
@display(users: Seq[User], id: Option[String] = None)(header: Html)(footer: Html) = {
<div class="mdl-cell mdl-cell--12-col mdl-shadow--2dp mdl-color--white" style="padding: 24px;" @if(id.isDefined){ id="@id.get" } >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il y a du stule embed

@display(users: Seq[User], id: Option[String] = None)(header: Html)(footer: Html) = {
<div class="mdl-cell mdl-cell--12-col mdl-shadow--2dp mdl-color--white" style="padding: 24px;" @if(id.isDefined){ id="@id.get" } >
<div>
<div style="font-size: 20px; color: black;" >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style embed

}
}
</table>
<div style="margin-top: 24px; margin-bottom: -24px;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style embed -> dans un fichier normalement

@footer
</div>
<div class="invisible">
<div style="text-align: center;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style embed -> dans un fichier normalement

@@ -125,7 +127,7 @@
@if(Authorization.canEditGroups(currentUserRights)) {
@helper.form(routes.UserController.add(userGroup.id), "method" -> "get") {
@helper.CSRF.formField
<div class="mdl-textfield mdl-js-textfield mdl-textfield--floating-label">
<div class="mdl-textfield mdl-js-textfield mdl-textfield--floating-label" style="width: unset; margin-right: 24px;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style embed -> dans un fichier normalement

@@ -1,5 +1,3 @@
@import models._
@import views.html.helper.CSRF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah bah comme quoi, tous les unused import dans les templates ne sont pas des faux positifs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants