tronquer PRENOM, NOMUSAGE, NOMNAISSANCE #678
Assignees
Comments
freesteph
added a commit
that referenced
this issue
Apr 4, 2024
Piggyback the `limit` option for ActiveModel's attribute method (which might be a thing one day[1]) to chop the value of the string directly on the XML-generating class. This keeps the mapping classes in charge of translating our data into the ASP stuff, semantically, but keeps the actual XML-maker in control of the formatted length, which makes more sense to me: all the XML tags have an associated length in the ASP documentation, so keeping it as close as possible to the XML generation code is nicer. Closes #678. [1]: rails/rails#51494
freesteph
added a commit
that referenced
this issue
Apr 4, 2024
Piggyback the `limit` option for ActiveModel's attribute method (which might be a thing one day[1]) to chop the value of the string directly on the XML-generating class. This keeps the mapping classes in charge of translating our data into the ASP stuff, semantically, but keeps the actual XML-maker in control of the formatted length, which makes more sense to me: all the XML tags have an associated length in the ASP documentation, so keeping it as close as possible to the XML generation code is nicer. Closes #678. [1]: rails/rails#51494
freesteph
added a commit
that referenced
this issue
Apr 4, 2024
Piggyback the `limit` option for ActiveModel's attribute method (which might be a thing one day[1]) to chop the value of the string directly on the XML-generating class. This keeps the mapping classes in charge of translating our data into the ASP stuff, semantically, but keeps the actual XML-maker in control of the formatted length, which makes more sense to me: all the XML tags have an associated length in the ASP documentation, so keeping it as close as possible to the XML generation code is nicer. It's also coherent with the custom :asp_date type which we use in a couple places (ie: prestadoss.rb) and takes care of formatting a date object in the format dictated by the ASP. Closes #678. [1]: rails/rails#51494
freesteph
added a commit
that referenced
this issue
Apr 4, 2024
Piggyback the `limit` option for ActiveModel's attribute method (which might be a thing one day[1]) to chop the value of the string directly on the XML-generating class. This keeps the mapping classes in charge of translating our data into the ASP stuff, semantically, but keeps the actual XML-maker in control of the formatted length, which makes more sense to me: all the XML tags have an associated length in the ASP documentation, so keeping it as close as possible to the XML generation code is nicer. It's also coherent with the custom :asp_date type which we use in a couple places (ie: prestadoss.rb) and takes care of formatting a date object in the format dictated by the ASP. Closes #678. [1]: rails/rails#51494
freesteph
added a commit
that referenced
this issue
Apr 8, 2024
Piggyback the `limit` option for ActiveModel's attribute method (which might be a thing one day[1]) to chop the value of the string directly on the XML-generating class. This keeps the mapping classes in charge of translating our data into the ASP stuff, semantically, but keeps the actual XML-maker in control of the formatted length, which makes more sense to me: all the XML tags have an associated length in the ASP documentation, so keeping it as close as possible to the XML generation code is nicer. It's also coherent with the custom :asp_date type which we use in a couple places (ie: prestadoss.rb) and takes care of formatting a date object in the format dictated by the ASP. Closes #678. [1]: rails/rails#51494
freesteph
added a commit
that referenced
this issue
Apr 8, 2024
Piggyback the `limit` option for ActiveModel's attribute method (which might be a thing one day[1]) to chop the value of the string directly on the XML-generating class. This keeps the mapping classes in charge of translating our data into the ASP stuff, semantically, but keeps the actual XML-maker in control of the formatted length, which makes more sense to me: all the XML tags have an associated length in the ASP documentation, so keeping it as close as possible to the XML generation code is nicer. It's also coherent with the custom :asp_date type which we use in a couple places (ie: prestadoss.rb) and takes care of formatting a date object in the format dictated by the ASP. Closes #678. [1]: rails/rails#51494
freesteph
added a commit
that referenced
this issue
Apr 8, 2024
Piggyback the `limit` option for ActiveModel's attribute method (which might be a thing one day[1]) to chop the value of the string directly on the XML-generating class. This keeps the mapping classes in charge of translating our data into the ASP stuff, semantically, but keeps the actual XML-maker in control of the formatted length, which makes more sense to me: all the XML tags have an associated length in the ASP documentation, so keeping it as close as possible to the XML generation code is nicer. It's also coherent with the custom :asp_date type which we use in a couple places (ie: prestadoss.rb) and takes care of formatting a date object in the format dictated by the ASP. Closes #678. [1]: rails/rails#51494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: