Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourcemaps #30

Closed
wants to merge 1 commit into from
Closed

sourcemaps #30

wants to merge 1 commit into from

Conversation

rap2hpoutre
Copy link
Member

@rap2hpoutre rap2hpoutre commented Jul 13, 2018

Add (experimental) sourcemaps for tags (and remove sourcemap from Awesomplete that is not relevant in our vendor file). See: #27 & riot/compiler#56 (comment)

EDIT :

Ajout de sourcemaps (expérimental) pour les tags (et suppression du sourcemap d'awsomplete qui n'a pas vraiment sa place ici). Voir : #27 & riot/compiler#56 (comment)

@rap2hpoutre rap2hpoutre requested a review from vinyll July 13, 2018 15:44
Copy link
Contributor

@vinyll vinyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne pense pas qu'on ait besoin des sourcemaps dans le build (prod).

Quoi qu'il en soit je ne vois pas de différence ; ca me fait toujours débugger du fichier compilé unique. Une idée ?

@rap2hpoutre
Copy link
Member Author

Ah merde, vu que c'est riot PUIS babel... grumph... je ferme cette PR en attendant et je vais chercher si ya un truc...

Bien vu !

@rap2hpoutre rap2hpoutre deleted the sourcemaps branch July 26, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants