-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature : objective cards #856
Open
oumeimaelisbihani
wants to merge
204
commits into
main
Choose a base branch
from
evolution/objective_cards
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oumeimaelisbihani
commented
Jun 27, 2024
- cartes objectives pour le parcours 'j'ai un objectif en tete'
…hould not be functionnal
Should be functionnal, not tested due to import issues. TODO: conditionnal sending
TODO : import fix + 2 fields in the payload needs info from PDE + conditionnal transmission if we are spammed !
… to be able to check if an opportunity should be sent to pde. Todo : implacement pde _reachedDailyContactTransmissionLimit which need a new BrevoAPICall
…evoDeal.ts Then i need to convert it back to domain type (hopefully to transform it into Opportunity ) and to propagate all the way to the PDE opportunity hub. Once done, this PR should be finished.
TODO: clean before merging.
# Conflicts: # packages/common/src/theme/types.ts # packages/web/src/utils/objective.ts
…lution/objective_cards
…lution/objective_cards
…t/create_JSON_files_from_baserows
TODO : field validations; export to file; Image
TODO: data validation.
# Conflicts: # apps/web/src/types/theme/types.ts # apps/web/src/utils/theme.ts # libs/common/src/index.ts
La dépendance `publicodes` a été mis à jours ! (1.3.3)
Feature principale : Génération des fichier projets pour le front (json + images) Features secondaire / détails d'implem : - récupération des données projets via baserow - création d'un script typescript indépendant qui génère les données via la commande "npm run generate:projects" - les données des projets sont stockés dans data/static/ - les images sont dans web/public/images/projet close #796 close #803 close #804 close #805 --------- Co-authored-by: Yohann Valentin <pro@yohannvalentin.com>
and fix the image path in the json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.