Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amélioration sur l’import #1253

Closed
6 tasks done
n-b opened this issue Sep 14, 2020 · 0 comments · Fixed by #1302
Closed
6 tasks done

Amélioration sur l’import #1253

n-b opened this issue Sep 14, 2020 · 0 comments · Fixed by #1302
Assignees
@n-b
Labels
fonctionnalité 👩‍💻 support
Projects
Place des entreprises

Comments

@n-b
Copy link
Collaborator

n-b commented Sep 14, 2020 •
edited

Tâches restantes après #1225; cf #1119, #1243

  • Additional Features (maybe in another PR)
    • automatic support for ; or , separators
    • Subjects matching
      • Support single-column subject for advisors
      • Less strict matching for subject headers
        Both involve reworking UserImpoerter#subjects_mapping. We also want to return an error if both the unique Subject column and subject-specific column are present
    • Support multiple subjects in importing serialized_description
  • UI (in another PR)
    • Find a nicer way to implement wide layout, where all the screen real estate is used, and it is scrollable
    • Make re-uploading after an error easier. At least, provide a link to the form.
  • Cleanup (in another PR)
    • Make the importer and exporter similar, as much as reasonable
    • Move them together in a CSVIO namespace
    • Move the “serialized_identifier” and “serialized_description” methods to the CSVIO namespace
@n-b n-b mentioned this issue Sep 14, 2020
Merged
3 tasks
@n-b n-b self-assigned this Sep 14, 2020
@n-b n-b added this to En cours in Place des entreprises Sep 14, 2020
This was referenced Sep 18, 2020
Merged
Merged
This was referenced Sep 25, 2020
Merged
Closed
Closed
n-b added a commit that referenced this issue Oct 2, 2020
@n-b
Move import/export buttons to the import pages
43e2dd4 
There’s some DRYing needed.

refs #1253
@n-b n-b mentioned this issue Oct 2, 2020
Merged
n-b added a commit that referenced this issue Oct 2, 2020
@n-b
WIP: Make sur the subject and description are always enough to find a…
6b568f2 
…n institution

-> test the new validations
-> simplify the csv_label method and fix the tests

refs #1253
n-b added a commit that referenced this issue Oct 2, 2020
@n-b
Move import/export buttons to the import pages
99f29c6 
There’s some DRYing needed.

refs #1253
n-b added a commit that referenced this issue Oct 5, 2020
@n-b
Move import/export buttons to the import pages
be24d50 
There’s some DRYing needed.

refs #1253
n-b added a commit that referenced this issue Oct 5, 2020
@n-b
Make sure InstitutionSubjects can be identifier by subject+description
2f7042b 
* Make the Subject label unique
* Make the InstitutionSubject [institution, subject, description] unique: it means that in an Institution, the same subject can only be selected several times if the description is different (and present.)

refs #1253
n-b added a commit that referenced this issue Oct 5, 2020
@n-b
Simplify the subject column name used in CSV exports and imports
27193f7 
On export, use just the subject as much as possible, and add the description if needed.
On import, allow different possible combinations, as long as it’s unambiguous.

refs #1253
@n-b n-b mentioned this issue Oct 5, 2020
Merged
n-b added a commit that referenced this issue Oct 6, 2020
@n-b
Make sure InstitutionSubjects can be identifier by subject+description
4d14e32 
* Make the Subject label unique
* Make the InstitutionSubject [institution, subject, description] unique: it means that in an Institution, the same subject can only be selected several times if the description is different (and present.)

refs #1253
n-b added a commit that referenced this issue Oct 6, 2020
@n-b
Simplify the subject column name used in CSV exports and imports
6f3c871 
On export, use just the subject as much as possible, and add the description if needed.
On import, allow different possible combinations, as long as it’s unambiguous.

refs #1253
n-b added a commit that referenced this issue Oct 6, 2020
@n-b
Make sure InstitutionSubjects can be identifier by subject+description
f8ca38e 
* Make the Subject label unique
* Make the InstitutionSubject [institution, subject, description] unique: it means that in an Institution, the same subject can only be selected several times if the description is different (and present.)

refs #1253
n-b added a commit that referenced this issue Oct 6, 2020
@n-b
Simplify the subject column name used in CSV exports and imports
56b7266 
On export, use just the subject as much as possible, and add the description if needed.
On import, allow different possible combinations, as long as it’s unambiguous.

refs #1253
n-b added a commit that referenced this issue Oct 6, 2020
@n-b
Refactor CSVExport and Import modules
d5f3024 
Methods and modules are now correctly namespaced.

At the high-level, it’s easier to call, like this:

```
Antenne.where(institution: institution).export_csv
Antenne.import_csv(file, institution: institution)
```

fixes #1253
@n-b n-b mentioned this issue Oct 6, 2020
Merged
n-b added a commit that referenced this issue Oct 8, 2020
@n-b
Refactor CSVExport and Import modules
cc37167 
Methods and modules are now correctly namespaced.

At the high-level, it’s easier to call, like this:

```
Antenne.where(institution: institution).export_csv
Antenne.import_csv(file, institution: institution)
```

fixes #1253
n-b added a commit that referenced this issue Oct 8, 2020
@n-b
Refactor CSVExport and Import modules
008ae1f 
Methods and modules are now correctly namespaced.

At the high-level, it’s easier to call, like this:

```
Antenne.where(institution: institution).export_csv
Antenne.import_csv(file, institution: institution)
```

fixes #1253
n-b added a commit that referenced this issue Oct 9, 2020
@n-b
Refactor CSVExport and Import modules
889c72d 
Methods and modules are now correctly namespaced.

At the high-level, it’s easier to call, like this:

```
Antenne.where(institution: institution).export_csv
Antenne.import_csv(file, institution: institution)
```

fixes #1253
@n-b n-b closed this as completed in #1302 Oct 13, 2020
Place des entreprises automation moved this from En cours to Prêt Oct 13, 2020
@n-b n-b moved this from Prêt to En production in Place des entreprises Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n-b n-b

Labels
fonctionnalité 👩‍💻 support
Projects
Conseillers-Entreprises
Archived in project
Place des entreprises
  
Sprint - En production
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor CSVExport and Import modules betagouv/conseillers-entreprises
1 participant
@n-b