Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Valider le format du numéro ANTS avant de consulter leur API (#4205)
* Reproduce crash with spec * Green spec, little refactor * Détecter le mauvais format de numéro ANTS avant d'appeler l'API * Keep it minimal * Cleanup merge * Considérer l'API ANTS comme fiable * Déplacer la validation sur User * Introduce ANTS helper methods and clarify specs * Fix User model spec * Share config and i18n between User and BeneficiaireForm * Please rubocop * Move to concern * Use I18n for unexpected API error too * Revert back to using a validator that takes a record * Feels safer * Cleanup * Bring back old code to minimize diff * Fix merge * Use explicit application_ids to prevent accidental matching * Use spec helpers * Please rubocop * Move ants_api.rb to app/lib * Fix merge
- Loading branch information
1 parent
1a7e14b
commit 1f6f5b2
Showing
13 changed files
with
218 additions
and
167 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.