Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active Rubocop Layout/LineLength #1356

Merged
merged 4 commits into from Apr 20, 2021
Merged

Active Rubocop Layout/LineLength #1356

merged 4 commits into from Apr 20, 2021

Conversation

n-b
Copy link
Contributor

@n-b n-b commented Apr 19, 2021

Suite de #1321, il y en aura d’autres. J’ai mis 200 caractères, ce qui est un peu large, mais ça reste raisonnable à mon goût et ça évite de devoir corriger trop de trucs. (Le défaut est 120)

(Descendre rubocop_todo.yml va prendre un peu de temps 😓 )

  • checklist avant review:
  • reparcourir le code rapidement pour voir les problèmes évidents (fichiers touched inutilement, debug logs qui trainent...).
  • Attendre que les tests soient verts sur la CI
  • Tester la fonctionnalité (si pertinent) sur la review app

@n-b n-b enabled auto-merge (squash) April 20, 2021 07:07
@n-b n-b merged commit d36def4 into master Apr 20, 2021
@n-b n-b deleted the rubocop-line-length branch April 20, 2021 07:47
@n-b n-b mentioned this pull request Apr 21, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaf yaf yaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n-b @yaf