Vider Redis entre chaque spec #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,6 +111,7 @@ | |||
| ActionMailer::Base.deliveries.clear | |||
| FactoryBot.rewind_sequences | |||
| Rails.cache.clear | |||
| Redis.with_connection { |redis| redis.del(redis.keys("*")) } # clears custom redis usages | |||
There was a problem hiding this comment.
Sur ma machine cet appel prend environ 0,452 ms. 🤷
https://redis.io/docs/data-types/sets/ Could not use command LPOS right now because redis-namespace does not support it. Besides, using a set is appropriate here.
This was referenced Mar 14, 2024
This was referenced Mar 26, 2024
Merged
This was referenced Apr 16, 2024
Closed
Merged
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J'ai eu un souci avec cette spec :
rdv-service-public/spec/mailers/custom_devise_mailer_domain_spec.rb
Line 12 in b37c1fd
La valeur stockée dans
"#{Rails.env}:user_session_domain:#{email}"n'était pas nettoyée, et il y a avait donc une fuite depuis un autre test dans lequel on avait écrit que le domaine était"RDV_AIDE_NUMERIQUE".Afin d'éviter les fuites j'ai utilisé la gem
redis-namespacepour utiliser un namespace différent par process parallèle.J'ai profité de l'occasion pour préfixer les clés que nous créons dans Redis via nos appels manuels (
Redis.with_connection). Cela permet de les lister facilement dans une base Redis.Checklist
Avant la revue :
Revue :