Corriger les warnings relevés par brakeman plutôt que de les ignorer #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-135
to
+136
| brakeman (5.3.1) | ||
| brakeman (6.1.2) | ||
| racc |
There was a problem hiding this comment.
J'ai lancé brakeman avant et après la MAJ, et il n'y a pas de nouvelles erreurs. 😉
Comment on lines
-21
to
+25
| mail.from %("#{domain.name}" <#{default_from}>) if mail.from.blank? | ||
| mail.from(rfc5322_name_and_email(domain.name, default_from)) if mail.from.blank? | ||
| end | ||
|
|
||
| def rfc5322_name_and_email(name, email) | ||
| %("#{name}" <#{email}>) |
There was a problem hiding this comment.
Ce code est testé, on peut le voir en cherchant " < dans les specs. 😉
| = render @motifs | ||
| = render partial: "admin/motifs/motif", collection: @motifs, as: :motif |
There was a problem hiding this comment.
Voir https://brakemanscanner.org/docs/warning_types/dynamic_render_paths/
Ça nous coûte pas cher d'utiliser cette version explicite, c'est plus lisible à mes yeux et ça rassure brakeman.
victormours
approved these changes
Apr 29, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Le fichier
brakeman.ignorecontient une liste de warnings brakeman que nous avons observés et décidé d'ignorer.Je trouve que ce fichier :
Je corrige donc ici les warnings relevés et je supprime
brakeman.ignore.Checklist
Avant la revue :
Revue :