Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppression de la dépendance HolderJS #4322

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

adipasquale
Copy link
Contributor

@adipasquale adipasquale commented Jun 4, 2024

Contexte

J’essaie de réduire un peu le poids des pages du layout application pour compenser le rajout du DSFR à venir

Problème

le package JS HolderJS n’est utilisé nulle part et il prend une part non négligeable du bundle application
Screenshot 2024-06-04 at 12 24 50

Solution

retirer la dépendance HolderJS pardi !

@adipasquale adipasquale marked this pull request as ready for review June 4, 2024 11:33
Copy link
Contributor

@francois-ferrandis francois-ferrandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour ton attention à ce sujet. 🙏

@@ -18,8 +18,6 @@ new Modal();
new Select2Inputs();

$(document).on('turbolinks:load', function() {
Holder.run();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ajouté par le dev initial le 8 juin 2020, en effet ça n'est plus utilisé. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants