Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY up users rdv wizard summary template + display it on step1 #934

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

adipasquale
Copy link
Contributor

@adipasquale adipasquale commented Oct 26, 2020

https://trello.com/c/hSR5M4xh/1128-afficher-le-r%C3%A9sum%C3%A9-du-rdv-sur-la-premi%C3%A8re-%C3%A9tape-du-wizard

  • affichage du summary sur la step1 du user rdv summary
  • deplacement du template app/views/users/rdvs/_summary_in_user_wizard.html.slim vers users/rdv_wizard_steps/_rdv_wizard_summary.html.slim
  • utilisation exclusive d'un UserRdvSummary dans ce template -> petit refacto de cet objet pour qu'il supporte l'absence de user
  • utilisation unique de ce template depuis les 3 steps + depuis les vues Devise
  • par effet de bord, le lien 'modifier' apparait maintenant depuis les vues Devise
  • correction visuelle de ce lien modifier dont la marge n'etait pas correcte

@adipasquale adipasquale force-pushed the feature/rdv-wizard-summary-improvements branch from dd400c7 to 6828015 Compare October 26, 2020 19:18
@adipasquale adipasquale marked this pull request as ready for review October 27, 2020 17:32
@adipasquale adipasquale merged commit de12c1e into master Oct 27, 2020
@adipasquale adipasquale deleted the feature/rdv-wizard-summary-improvements branch October 27, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant