deleted unused fond or create method

betagouv · Apr 17, 2020 · 8396445 · 8396445
1 parent e721913
commit 8396445
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 20 deletions.
diff --git a/sqlalchemy_api_handler/api_handler.py b/sqlalchemy_api_handler/api_handler.py
@@ -2,11 +2,10 @@
 from sqlalchemy import BigInteger,\
                        Column
 
-from sqlalchemy_api_handler.bases.find_or_create import FindOrCreate
 from sqlalchemy_api_handler.bases.save import Save
 from sqlalchemy_api_handler.utils.human_ids import humanize
 
-class ApiHandler(Save, FindOrCreate):
+class ApiHandler(Save):
 
     id = Column(BigInteger,
                 primary_key=True,

diff --git a/sqlalchemy_api_handler/bases/find_or_create.py b/sqlalchemy_api_handler/bases/find_or_create.py
diff --git a/tests/bases/populate_test.py b/tests/bases/populate_test.py
@@ -302,28 +302,34 @@ def test_raises_type_error_if_raw_humanized_id_is_invalid(self):
     @clean_database
     def test_create_or_update_returns_new_created_offer(self, app):
         # Given
-        offer = Offer(name='foo', type='bar')
-        ApiHandler.save(offer)
+        offer1 = Offer(name='foo', type='bar')
+        ApiHandler.save(offer1)
 
         # When
-        offer2 = Offer.create_or_modify({ 'name': 'fee', 'type': 'bric' }, search_by='name')
+        offer1 = Offer.create_or_modify(
+            { 'name': 'fee', 'type': 'bric' },
+            search_by='name'
+        )
 
         # Then
-        assert offer2.id != offer.id
+        assert offer2.id != offer1.id
         assert offer2.name == 'fee'
         assert offer2.type == 'bric'
 
 
     @clean_database
     def test_create_or_update_returns_modified_existing_offer(self, app):
         # Given
-        offer = Offer(name="foo", type="bar")
-        ApiHandler.save(offer)
+        offer1 = Offer(name="foo", type="bar")
+        ApiHandler.save(offer1)
 
         # When
-        offer2 = Offer.create_or_modify({ 'name': 'foo', 'type': 'bric' }, search_by='name')
+        offer2 = Offer.create_or_modify(
+            { 'name': 'foo', 'type': 'bric' },
+            search_by='name'
+        )
 
         # Then
-        assert offer2.id == offer.id
+        assert offer2.id == offer1.id
         assert offer2.name == 'foo'
         assert offer2.type == 'bric'