Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash while trying to parse a diff for binary files, fix #128 #242

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

exAspArk
Copy link
Contributor

@exAspArk exAspArk commented Aug 22, 2022

image

Error: Cannot read property 'startsWith' of undefined

Config:

bar/foo@master:
  - test.txt

To reproduce, change a binary file (e.g., *.gz) in a commit with test.txt and try to sync it

Fixes #128

@exAspArk exAspArk marked this pull request as ready for review August 22, 2022 20:44
@exAspArk exAspArk force-pushed the fix-binary-files branch 3 times, most recently from 10354a8 to df0d160 Compare August 23, 2022 13:15
@exAspArk exAspArk marked this pull request as draft August 23, 2022 13:16
@exAspArk exAspArk marked this pull request as ready for review August 23, 2022 13:24
@BetaHuhn BetaHuhn merged commit ca2043b into BetaHuhn:master Aug 24, 2022
@BetaHuhnBot
Copy link
Collaborator

🎉 This PR is included in version 1.17.21 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when sync an empty file
3 participants