Adding a unit test for binary IDs and relations... #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6utt3rfly
added a commit
that referenced
this pull request
Nov 26, 2018
* Fix withRelated not always grouping properly for binary IDs - When grouped relations, convert Buffers to hex strings to use as the mapping key * Adding a unit test for binary IDs and relations... * - Fixed collections not being created properly with binary IDs due to collection keying again - Added a collection test with binary IDs * Adding a unit test for binary IDs and relations... (#1) * - Remove 'Issue #xx' from unit test comment - Remove 'debug:true' from unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests, fixed collections with binary IDs as well