Merge Rory Locals #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… secondary serialise calls. Add enums to have complete coverage of enums from betfair docs. Add price levels and time functions to utils.
… clean_locals to utils.
…faults to use defined enums/filters.
… method. Map all filters to use actual param names.
|
Hi, This is a huge pull request, hopefully I will get some time to review / understand the use of locals, also very keen to add the order filter. |
|
Hey mate,
Yeah it's fairly huge to be honest haven't done a whole heap of PRs on open source and I know I broke all your tests will get some time to fix them soon hopefully!
Any feedback on it is appreciated.
Cheers
Rory
…Sent from my iPhone
On 17 Feb 2017, at 20:24, Liam ***@***.***> wrote:
Hi,
This is a huge pull request, hopefully I will get some time to review / understand the use of locals, also very keen to add the order filter.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Making small PR's makes it much easier to merge my side especially if they involve breaking changes. Let me know if you able to split this up. |
Closed
|
All now pushed to version 1, thanks! |
|
@rozzac90 , do you think you could, with @liampauling 's blessing, cherry-pick out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging some nice functionality from a local betfair wrapper.
Move all account and betting endpoints to have params named in method rather than just a params arg.
Include doc strings for all account and betting endpoints.
Extend enums to cover all betting enums and include doc strings with variable explanations.
Extend subscribe_to_orders method to accept orderFilter, usefult for distinguishing order to subscribe to by strategyRef.
Add some commonly used methods to utils.