Call stop before raising SocketError in _read_loop #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've moved the socket cleanup code into
stop
and called it before raising SocketError.I had to modify one of the tests since it was expecting a SocketError but the stop code was causing a different exception to be thrown as the socket was mocked and it was trying to call a non-existent method.
Maybe it would have been better to mock the
shutdown
andclose
methods on the socket instead?