Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles table #92

Closed
wants to merge 5 commits into from
Closed

Roles table #92

wants to merge 5 commits into from

Conversation

nate-li
Copy link
Contributor

@nate-li nate-li commented Feb 25, 2016

No description provided.

@c-schwarze
Copy link
Contributor

@nate-li could you merge with master? click on "Update from master" on the github desktop?

It will update your pull request with the master's commits.

@e-chapin
Copy link

@c-schwarze what do you think about storing all the "admin" things under one blueprint, so we don't end up with a large amount of top level folders in the project?

@c-schwarze
Copy link
Contributor

Nathan is going to do that next time he is in.

@e-chapin
Copy link

Oh okay, cool.

@e-chapin
Copy link

API-12 Testing something, ignore this

@c-schwarze
Copy link
Contributor

Oh, also, @nate-li, the code looks good.

Does this need to be in the views.py file? It looks like you aren't using it:

"""@blink_roles_blueprint.route('/role/<uid>/<portal>')
def role_redirect():
    uid_list = uid
    portal_list = portal"""

@e-chapin
Copy link

Does this do any security checking based on groups or roles, etc to restrict access? Even if the Admin nav item does it, it might be smart to check before each request. I believe we can do something like

@blueprint_name.before_request just like we do @app.before_request so it checks it before any request to the admin blueprint.

@e-chapin
Copy link

Closing as this overlaps with #110

@e-chapin e-chapin closed this Mar 21, 2016
@c-schwarze c-schwarze deleted the roles-table branch June 7, 2016 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants