-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding preprocessing to all models #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution, @wielandbrendel !
Could you update the Keras ResNet example in the README to use the new preprocessing?
Then it should be ready to merge and I'll publish it as version 0.9.0.
_loss_fn was only added to implement the tests, right? It should be clear that _loss_fn should only used for these internal tests and should not be relied on by users because that interface is likely to change when we generalize the predictions and gradient calculations in future versions.
@jonasrauber Good point, I forgot about the readme. Should be fixed now. Regarding _loss_fn: this will be refactored soon anyway when we generalise the handling of the loss. Lets not bother until then. |
|
No description provided.