Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding preprocessing to all models #39

Merged
merged 13 commits into from
Jul 21, 2017
Merged

Adding preprocessing to all models #39

merged 13 commits into from
Jul 21, 2017

Conversation

wielandbrendel
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jul 21, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling aef287a on wielandbrendel:preprocessing into 2c4d327 on bethgelab:master.

Copy link
Member

@jonasrauber jonasrauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution, @wielandbrendel !

Could you update the Keras ResNet example in the README to use the new preprocessing?
Then it should be ready to merge and I'll publish it as version 0.9.0.

_loss_fn was only added to implement the tests, right? It should be clear that _loss_fn should only used for these internal tests and should not be relied on by users because that interface is likely to change when we generalize the predictions and gradient calculations in future versions.

@coveralls
Copy link

coveralls commented Jul 21, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 40dd264 on wielandbrendel:preprocessing into 2c4d327 on bethgelab:master.

@wielandbrendel
Copy link
Member Author

@jonasrauber Good point, I forgot about the readme. Should be fixed now. Regarding _loss_fn: this will be refactored soon anyway when we generalise the handling of the loss. Lets not bother until then.

@jonasrauber
Copy link
Member

Regarding _loss_fn: this will be refactored soon anyway when we generalise the handling of the loss. Lets not bother until then.
@wielandbrendel That's what I meant ;-)

@jonasrauber jonasrauber merged commit 659534c into bethgelab:master Jul 21, 2017
@wielandbrendel wielandbrendel deleted the preprocessing branch July 22, 2017 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants