Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LACE-626 | Try to run tests using Python 3.9 #11

Merged
merged 12 commits into from Mar 5, 2021
Merged

LACE-626 | Try to run tests using Python 3.9 #11

merged 12 commits into from Mar 5, 2021

Conversation

macbre
Copy link
Contributor

@macbre macbre commented Jan 19, 2021

@macbre macbre enabled auto-merge January 19, 2021 12:34
@macbre
Copy link
Contributor Author

macbre commented Jan 19, 2021

nox > poetry run pylint src tests noxfile.py cli.py
************* Module src.pythink_toolbox.validating
src/pythink_toolbox/validating.py:59:30: E1136: Value 'Optional' is unsubscriptable (unsubscriptable-object)
src/pythink_toolbox/validating.py:110:10: E1136: Value 'Optional' is unsubscriptable (unsubscriptable-object)
************* Module src.pythink_toolbox.testing.parametrization
src/pythink_toolbox/testing/parametrization.py:7:0: E0239: Inheriting 'TypedDict', which is not a class. (inherit-non-class)
src/pythink_toolbox/testing/parametrization.py:7:0: R0903: Too few public methods (0/2) (too-few-public-methods)
src/pythink_toolbox/testing/parametrization.py:19:25: E1136: Value 'Union' is unsubscriptable (unsubscriptable-object)
src/pythink_toolbox/testing/parametrization.py:24:20: E1136: Value 'Union' is unsubscriptable (unsubscriptable-object)
************* Module tests.test_validating
tests/test_validating.py:14:12: E1136: Value 'Optional' is unsubscriptable (unsubscriptable-object)
tests/test_validating.py:17:15: E1136: Value 'Optional' is unsubscriptable (unsubscriptable-object)
tests/test_validating.py:12:0: R0903: Too few public methods (0/2) (too-few-public-methods)
tests/test_validating.py:75:12: E1136: Value 'Optional' is unsubscriptable (unsubscriptable-object)
tests/test_validating.py:78:15: E1136: Value 'Optional' is unsubscriptable (unsubscriptable-object)
tests/test_validating.py:91:0: R0903: Too few public methods (0/2) (too-few-public-methods)
tests/test_validating.py:132:0: R0903: Too few public methods (0/2) (too-few-public-methods)
************* Module tests.test_testing.test_paramatrization
tests/test_testing/test_paramatrization.py:9:0: R0903: Too few public methods (0/2) (too-few-public-methods)

-----------------------------------
Your code has been rated at 7.06/10

http://pylint-messages.wikidot.com/messages:e1136 + pylint-dev/pylint#3882 (seems to be blocked on pylint-dev/pylint#3890 which has not yet been released)

@miloszbednarzak
Copy link
Contributor

@macbre by default we check python 3.9, but we don't require it to pass yet. We just check it to be sure if we are ready to switch to 3.9. But if we want to use 3.9 in Chronos we need pythink-toolbox to pass 3.9 checks also.

Co-authored-by: Milosz Bednarzak <33376065+miloszbednarzak@users.noreply.github.com>
@macbre
Copy link
Contributor Author

macbre commented Jan 19, 2021

The latest Pylint 2.6.0 still does not support Python 3.9 -> pylint-dev/pylint@2a86092 is still in master.

The question is - do we want to wait for Pylint with Python 3.9 to be released or do we simply ignore pylint warnings in Python 3.9 build for now and tag a new version of pythink-toolbox? @miloszbednarzak ?

@miloszbednarzak
Copy link
Contributor

@macbre I'd rather wait than ignore pylint. Pylint is our guardian angel, so I want to bet on it.
Also maintainers "promised" that release will be soon: pylint-dev/pylint#3882 (comment)

Waiting for Python 3.9-compatible pylint
@macbre macbre marked this pull request as draft January 20, 2021 10:00
auto-merge was automatically disabled January 20, 2021 10:00

Pull request was converted to draft

@macbre macbre changed the title Try to run tests using Python 3.9 LACE-626 | Try to run tests using Python 3.9 Jan 20, 2021
@macbre
Copy link
Contributor Author

macbre commented Feb 4, 2021

https://github.com/PyCQA/pylint/milestone/24 - pylint's 2.6.1 milestone is only 41% complete now. We have to wait...

@macbre
Copy link
Contributor Author

macbre commented Feb 22, 2021

nox > poetry run pylint src tests noxfile.py cli.py
************* Module src.pythink_toolbox.testing.parametrization
src/pythink_toolbox/testing/parametrization.py:7:0: R0903: Too few public methods (0/2) (too-few-public-methods)
************* Module tests.test_validating
tests/test_validating.py:12:0: R0903: Too few public methods (0/2) (too-few-public-methods)
tests/test_validating.py:91:0: R0903: Too few public methods (0/2) (too-few-public-methods)
tests/test_validating.py:132:0: R0903: Too few public methods (0/2) (too-few-public-methods)
************* Module tests.test_testing.test_paramatrization
tests/test_testing/test_paramatrization.py:9:0: R0903: Too few public methods (0/2) (too-few-public-methods)

@macbre macbre marked this pull request as ready for review March 5, 2021 09:27
@macbre macbre enabled auto-merge March 5, 2021 09:27
@macbre macbre merged commit 31fb6ee into master Mar 5, 2021
@macbre macbre deleted the python-3.9 branch March 5, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants