Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKCartesianChart: Bad calculation of ScaleDataToPixels in some cases #795

Closed
dlucazeau opened this issue Dec 1, 2022 · 1 comment
Closed
Labels
bug Something isn't working priority 0 needs to be fixed asap.

Comments

@dlucazeau
Copy link

I use the two libraries mentioned in the Desktop part to build charts and embed them in mails.
I already have several operational ones. I'm doing a console program to develop this new graph.
I thank you for all your work on which I build mine.

Bug Description
The pixel coordinates of the origin (0,0), computed with the ScaleDataToPixels() method of SKCartesianChart are good if the legend is placed on the right or on the bottom. But they are not good if the legend is placed on the top or on the left.
The images are based on the same code, only the location of the legend changes from one image to another.
I use the coordinates of the origin to draw my circle reference lines.

To Reproduce
The main code used is attached.

Expected Behavior
The calculation done by ScaleDataToPixels should be correct regardless of the location of the legend.

Screenshots
image
image
image
image

and hidden :
image

Desktop:

  • OS: Windows 10
  • Browser No browser, it's a console application with a SaveImage()
  • Version LiveCharts.Core@0.9.8 & SkiaSharp@2.88.3

sample-code.txt

@beto-rodriguez beto-rodriguez added the bug Something isn't working label Dec 19, 2022
@beto-rodriguez beto-rodriguez added the priority 1 might not be fixed in the next release of the library, but it will soon! label Mar 3, 2023
@beto-rodriguez
Copy link
Owner

This is now fixed and this case was added to test, thanks for the report, it will be included in the next version of the library.

beto-rodriguez added a commit that referenced this issue Jun 6, 2023
@beto-rodriguez beto-rodriguez added priority 0 needs to be fixed asap. and removed priority 1 might not be fixed in the next release of the library, but it will soon! labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority 0 needs to be fixed asap.
Projects
None yet
Development

No branches or pull requests

2 participants