Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 100 #111

Merged
merged 9 commits into from
Jul 28, 2021
Merged

Bugfix 100 #111

merged 9 commits into from
Jul 28, 2021

Conversation

CodeWithMichal
Copy link
Contributor

Solving issue #100

@beto-rodriguez
Copy link
Owner

it works thanks!

I made some format changes and also extended the fix for financial and row series (the issue might also be there).

I also made a possible performance improvement, they may be cases where your code is faster than mine, but the idea was to get over the duplicated query:

 _chartView.Series.Where(s => s.IsColumnSeries())
/// then
_chartView.Series.Where(s => !s.IsColumnSeries()) 

@beto-rodriguez beto-rodriguez merged commit 96bb9ea into beto-rodriguez:master Jul 28, 2021
@CodeWithMichal
Copy link
Contributor Author

I am glad it does! Dont worry about changing my code or telling its a trash whenever it is :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants