Use ICollection interface instead #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Series.Valuesis of typeIEnumerablewhile this is a flexible type, it also causes some confusion, users are using LINQ expressions as the data source, Linq expressions are evaluated every time the library needs read the data in the chart, this is not optimal for performance and could also lead to some visual glitches.This is a recurrent issue with new users, some related issues are:
This PR changes the
Series.Valuestype toICollection, this prevents users from using LINQ expressions as the data source and we can still useList<T>,ObservableCollection<T>, arrays,Queue<T>,Stack<T>,HashSet<T>and a lot of useful structures in dotnet.