Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Eto.Forms #388

Merged
merged 42 commits into from
Feb 16, 2022
Merged

Port to Eto.Forms #388

merged 42 commits into from
Feb 16, 2022

Conversation

rafntor
Copy link
Contributor

@rafntor rafntor commented Feb 7, 2022 •
edited

Ref discussion here ; #381

- Needs rebase

@rafntor rafntor marked this pull request as draft February 7, 2022 20:39
@rafntor
copy winforms lib & sample-app to eto equivalent
6cb4bd4
@rafntor
allow InternalsVisibleTo("LiveChartsCore.SkiaSharpView.Eto.Forms")
f4cb4ca
@rafntor
rename namespaces winforms->eto.forms
1bd0f22
@rafntor
initial porting steps for view lib
65fa709
@rafntor
initial porting steps for sample app
0617503
@rafntor
delete winforms.designer files
619d864
@rafntor
mass-replace windows.forms -> eto equivalents
501e197
@rafntor
fix motioncanvas ; inherit skiadrawable
b0946ee
@rafntor
first working chart
32306bb
@rafntor
color assignments; components order fix
aa3cbeb
@rafntor
all charts handled
48956db
@rafntor
fix view deactivation/destruction
ea1fea5
@rafntor
handle legend-positioning (hopefully)
31b470e
@rafntor
fix typo
21be71f
@rafntor
default to white chart background / system tooltipcolor
03f0d88
@rafntor
implement tooltip classes
c2b903d
@rafntor
implement legend classes
87977f9
@rafntor
add some info in demoapp title
95a1e55
@rafntor
improve tooltip, get border by adding groupbox, location when size ch…
53b657c 
…ange
@rafntor
dont need explicit scrollable, listbox will make it automatically
e35f91c
@rafntor
fix tooltip border
615e3f2
@rafntor
tooltip form must autosize for series where number of points vary
acde3fb
@rafntor
fix button layout views
5d35762
@rafntor
splitters dont work properly ; use dynamiclayout
9bbb41e
@rafntor
stacklayout dont work properly ; use dynamiclayout
1549db5
@rafntor
add samples skeleton that is missing in winforms sampleapp
422ff59
@rafntor
add image to mainform
a5c08fe
@rafntor
reimplement views
4a741c8
@rafntor
fix tooltip background color
1c810b0
@rafntor rafntor marked this pull request as ready for review February 8, 2022 17:37
@rafntor
Copy link
Contributor Author

rafntor commented Feb 8, 2022

@beto-rodriguez - Please have a look and see what you think ;-)

@rafntor rafntor changed the title [wip] Port to Eto.Forms Port to Eto.Forms Feb 9, 2022
@rafntor
Copy link
Contributor Author

rafntor commented Feb 9, 2022 •
edited

Databindings are not implemented, other than that the samples should work OK. (Chart-Properties handled similar ways as the Winforms implementation)

beto-rodriguez
beto-rodriguez approved these changes Feb 16, 2022
View reviewed changes
Copy link
Owner

@beto-rodriguez beto-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay and thanks for this huge contribution, I will push the NuGet packages with the next release.

@beto-rodriguez beto-rodriguez merged commit 930bf29 into beto-rodriguez:master Feb 16, 2022
@rafntor rafntor deleted the eto_port branch February 17, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beto-rodriguez beto-rodriguez beto-rodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rafntor @beto-rodriguez