Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StepLine Series #61

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

CodeWithMichal
Copy link
Contributor

@CodeWithMichal CodeWithMichal commented Jun 16, 2021

Mostly its copy-pasted from LineSeries so please take a close look :)
I feel its an overkill with creating StepLineVisualChartPoint for the purpose of StepLine Series since there is already a LineSegment which could probably be used but I got lost with abstraction layer... I would love to simplify it if you could share some tips :)

For now there are only samples for WPF available - I will add all the rest once it could be merged

@beto-rodriguez
Copy link
Owner

I like your idea.

So, you basically just copy pasted the LineSeries and used the segment you created, the StepLineSegment, I like it.

Let me try in your branch to simplify it, I agree with you, I think we can, I will try that the StepLineSeries inherits from LineSeries but using a different type (IStepLineSegment) .

@CodeWithMichal
Copy link
Contributor Author

Well, I slightly changed it as well but only some minor stuff like deleting smoothness property or deleting nullsplitting (i think its not apllicable)

@beto-rodriguez
Copy link
Owner

The null splitting creates the "gaps effect", like the following image, maybe it is also useful for the step line series.

image

@beto-rodriguez
Copy link
Owner

beto-rodriguez commented Jun 16, 2021

I will check it now, will come back with more news in a few hours.

@beto-rodriguez beto-rodriguez merged commit 4ae9055 into beto-rodriguez:master Jun 16, 2021
@beto-rodriguez
Copy link
Owner

beto-rodriguez commented Jun 16, 2021

I merged it by mistake before I wanted 😄

But everything seems right, I added multiple fixes, take a look at the git history, I also added a couple of missing features:

Now we can add gaps to step lines:

image

The library now supports stacked step lines:

image

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants