fix: no warning when importing unrequested adapter #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cancan101
reviewed
Mar 11, 2022
| @@ -500,17 +500,20 @@ def connect( | |||
| [(1.0, 2.0), (3.0, 4.0)] | |||
|
|
|||
| """ | |||
| if adapters is None and safe: | |||
There was a problem hiding this comment.
I would say the control flow around safe is a bit hard to follow .
There was a problem hiding this comment.
Thanks for the feedback! Yeah, I agree it could be improved. It's also not perfect, as someone might be able to monkeypatch an unsafe adapter to mark it as safe. It probably need some refactoring.
BTW, did you get my email? Sometimes my email gets classified as spam because I self host it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
connectso that when a list ofadaptersis passed, we only try to load adapters from that list.It also fixes a type error introduced in #187.
Closes #194.