Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use better JSONPath library #431

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix: use better JSONPath library #431

merged 1 commit into from
Feb 22, 2024

Conversation

betodealmeida
Copy link
Owner

Summary

Use python-jsonpath instead of jsonpath-python, since it handles the root ($) better.

Testing instructions

@betodealmeida betodealmeida enabled auto-merge (squash) February 22, 2024 20:16
@betodealmeida betodealmeida merged commit f40fa60 into main Feb 22, 2024
7 of 8 checks passed
@cwegener
Copy link
Collaborator

How does it compare to jsonpath-ng ? https://github.com/h2non/jsonpath-ng

@betodealmeida
Copy link
Owner Author

How does it compare to jsonpath-ng ? https://github.com/h2non/jsonpath-ng

Ah, I wasn't aware of that library. Looks like a nice solution, and it handles the root path correctly.

@cwegener
Copy link
Collaborator

How does it compare to jsonpath-ng ? https://github.com/h2non/jsonpath-ng

Ah, I wasn't aware of that library. Looks like a nice solution, and it handles the root path correctly.

It's been in use in https://github.com/meltano/sdk and I've used that one quite a bit and it does the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shillelagh error: 'str' object has no attribute 'items' in superset
2 participants