Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce commonjs package manager support #36

Conversation

venkateshsampath
Copy link

This patch is to allow use of commonjs package manager and es6 modules.
courtesy: https://github.com/angular-ui/ui-router
example:
import ngInputModified from 'angular-input-modified';
angular.module('foo', [ngInputModified]);

This patch is to allow use of commonjs package manager and es6 modules.
courtesy: https://github.com/angular-ui/ui-router
example:
import ngInputModified from 'angular-input-modified';
angular.module('foo', [ngInputModified]);
@venkateshsampath
Copy link
Author

Hi @slavafomin & Team,

Thanks for this nice extension. It helped us to meet one of our requirements in our projects in a cleaner way.
Since we were using webpack module bundler with es6 in our project, we were facing few problem in importing the ngInputModified module as it needs commonjs package manager support.
Noticed a simple solution provided at angular-ui-router. Applied a similar fix for angular-input-modified too and submitting this PR.
Can you guys please review my changes and merge the patch if it looks ok.
Request you to please publish a new npm package so that we could use it with webpack and es6.

@slavafomin
Copy link
Member

Thank you @venkateshsampath! I will take a look at this. Sorry for a long delay.

@slavafomin
Copy link
Member

Hello @venkateshsampath, could you please create a small project that requires input-modified and builds a bundle using webpack? Maybe add some integration tests to it too? Then I will be able to update our module to make it compatible with your build tools.

@slavafomin
Copy link
Member

@venkateshsampath please see #37.

@slavafomin slavafomin closed this Feb 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants