New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages doesn't use App namespace #4

Merged

smpita merged 2 commits into main from use-guaranteed-middleware

Sep 29, 2023

Collaborator

smpita commented Sep 29, 2023

We should probably consider pulling these out to a config, but I'm not ready to deal with config type issues.

For now, we should at minimum guarantee the middlewares exist by using the unpublished vendor copy.

smpita and others added 2 commits

September 29, 2023 12:50


          Package doesn't have App

58e8ff1


          Merge branch 'main' into use-guaranteed-middleware

7c06ca0

AbdelElrafa approved these changes

View reviewed changes

Collaborator

AbdelElrafa left a comment

They can override these using the modifyPanelUsing static method, so I'm okay with this.

smpita merged commit 76b8b0e into main

9 checks passed

smpita deleted the use-guaranteed-middleware branch

September 29, 2023 21:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment