handle timestamps with timezones set #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 1, 2019
convoys/utils.py
Outdated
| @@ -108,13 +108,13 @@ def _calculate_T(row): | |||
| if now is not None: | |||
| return _sub(row[now], row[created]) | |||
| else: | |||
| return _sub(datetime.datetime.now(), row[created]) | |||
| return datetime.datetime.now(tz=row[created].tzinfo) - row[created] | |||
|
realized this bug wasn't fixed, my test code was broken. will fix later. |
|
kind of silly that this is 40 lines of test for 3 lines of code, but whatev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no reason to have to set
nowexplicitly going forwardanother minor fix that came up