Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weibull regression (MAP and bayesian version) #6

Merged
merged 4 commits into from
Feb 8, 2018

Conversation

erikbern
Copy link
Contributor

@erikbern erikbern commented Feb 7, 2018

Implemented a regression model using pymc3, so fully Bayesian.

The good news is that it was very easy to implement (once I discovered the pymc3.Potential class). The bad news is this is slow as hell. It barely works for more than a few thousand datapoints – whereas the current models happily fit 100k datapoints in a few seconds.

I'm tempted to revert to my original idea of just fitting this using MAP and then computing the Hessian of the MAP to get a normal approximation of the posterior distribution. Seems a bit janky but I think it will be a pretty good approximation in practice, and probably ~100x faster.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.6%) to 69.296% when pulling eb25d19 on weibull-regression into 62c0e24 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.6%) to 69.296% when pulling eb25d19 on weibull-regression into 62c0e24 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.6%) to 69.296% when pulling eb25d19 on weibull-regression into 62c0e24 on master.

@coveralls
Copy link

coveralls commented Feb 7, 2018

Coverage Status

Coverage decreased (-3.8%) to 68.031% when pulling 05bcbf3 on weibull-regression into 62c0e24 on master.

@erikbern
Copy link
Contributor Author

erikbern commented Feb 7, 2018

will repurpose this to a straightforward MAP using scipy.optimize

@erikbern erikbern changed the title weibull regression using pymc3 weibull regression (MAP and bayesian version) Feb 8, 2018
@erikbern erikbern merged commit 896b02c into master Feb 8, 2018
@erikbern erikbern deleted the weibull-regression branch February 8, 2018 19:09
@erikbern
Copy link
Contributor Author

erikbern commented Feb 8, 2018

merging this for now since it doesn't interfere with any of the existing code

kind of annoying to have three different versions of the same tool though, i might unify it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants