increase the number of burn-in steps #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 21, 2018
convoys/regression.py
Outdated
| dim, nwalkers, i+1, nburnin+nsteps)) | ||
| sys.stdout.flush() | ||
| sys.stdout.write('\n') | ||
| result['samples'] = sampler.chain[:, nburnin:, :].reshape((-1, dim)).T |
There was a problem hiding this comment.
line too long (82 > 79 characters)
convoys/regression.py
Outdated
| data = x0 | ||
| sys.stdout.write('\n') | ||
| for i, _ in enumerate(sampler.sample(p0, iterations=nburnin+nsteps)): | ||
| sys.stdout.write('MCMC in %d dimensions with %d walkers: %6d/%-6d\r' % ( |
There was a problem hiding this comment.
line too long (88 > 79 characters)
convoys/regression.py
Outdated
| else: | ||
| data = x0 | ||
| sys.stdout.write('\n') | ||
| for i, _ in enumerate(sampler.sample(p0, iterations=nburnin+nsteps)): |
There was a problem hiding this comment.
line too long (81 > 79 characters)
houndci-bot
reviewed
Aug 21, 2018
convoys/regression.py
Outdated
| print('\n') | ||
| sys.stdout.write('\n') | ||
| for i, _ in enumerate(sampler.sample(p0, iterations=nburnin+nsteps)): | ||
| sys.stdout.write('MCMC in %d dimensions with %d walkers: %6d/%-6d\r' % ( |
There was a problem hiding this comment.
line too long (88 > 79 characters)
convoys/regression.py
Outdated
| sampler.run_mcmc(p0, nburnin+nsteps) | ||
| print('\n') | ||
| sys.stdout.write('\n') | ||
| for i, _ in enumerate(sampler.sample(p0, iterations=nburnin+nsteps)): |
There was a problem hiding this comment.
line too long (81 > 79 characters)
Merged
houndci-bot
reviewed
Aug 22, 2018
convoys/regression.py
Outdated
| @@ -205,6 +209,8 @@ def fit(self, X, B, T, W=None, fix_k=None, fix_p=None): | |||
| sys.stdout.write('\n') | |||
| result['samples'] = sampler.chain[:, n_burnin:, :] \ | |||
| .reshape((-1, dim)).T | |||
| if fix_k: result['samples'][0, :] = log(fix_k) | |||
| if fix_p: result['samples'][1, :] = log(fix_p) | |||
There was a problem hiding this comment.
multiple statements on one line (colon)
convoys/regression.py
Outdated
| @@ -205,6 +209,8 @@ def fit(self, X, B, T, W=None, fix_k=None, fix_p=None): | |||
| sys.stdout.write('\n') | |||
| result['samples'] = sampler.chain[:, n_burnin:, :] \ | |||
| .reshape((-1, dim)).T | |||
| if fix_k: result['samples'][0, :] = log(fix_k) | |||
There was a problem hiding this comment.
multiple statements on one line (colon)
convoys/regression.py
Outdated
| @@ -181,6 +181,10 @@ def fit(self, X, B, T, W=None, fix_k=None, fix_p=None): | |||
| ) | |||
| result = {'map': res.x} | |||
|
|
|||
| # TODO: should not use fixed k/p as search parameters | |||
| if fix_k: result['map'][0] = log(fix_k) | |||
| if fix_p: result['map'][1] = log(fix_p) | |||
There was a problem hiding this comment.
multiple statements on one line (colon)
convoys/regression.py
Outdated
| @@ -181,6 +181,10 @@ def fit(self, X, B, T, W=None, fix_k=None, fix_p=None): | |||
| ) | |||
| result = {'map': res.x} | |||
|
|
|||
| # TODO: should not use fixed k/p as search parameters | |||
| if fix_k: result['map'][0] = log(fix_k) | |||
There was a problem hiding this comment.
multiple statements on one line (colon)
houndci-bot
reviewed
Aug 22, 2018
convoys/regression.py
Outdated
| # Callback for progress to stdout | ||
| n_iterations = [0] # Dumb hack to make the scope right | ||
| sys.stdout.write('\n') | ||
| def callback(x): |
There was a problem hiding this comment.
expected 1 blank line before a nested definition, found 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed it makes a huge difference