Skip to content

Commit

Permalink
Remove --update and replace with --no-cache for apk in Dockerfile
Browse files Browse the repository at this point in the history
There is no need to use `--update` with `--no-cache`, only `--no-cache`
should be used when building a Docker image, as using `--no-cache` will
fetch the index every time and leave no local cache, so the index will
always be the latest and without temporary files remains in the image.
  • Loading branch information
PeterDaveHello committed Sep 12, 2021
1 parent 74e3303 commit e81f36c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Dockerfile
Expand Up @@ -3,8 +3,8 @@ FROM golang:alpine AS build-env

ENV SRC_DIR $GOPATH/src/github.com/bettercap/bettercap

RUN apk add --update ca-certificates
RUN apk add --no-cache --update bash iptables wireless-tools build-base libpcap-dev libusb-dev linux-headers libnetfilter_queue-dev git
RUN apk add --no-cache ca-certificates
RUN apk add --no-cache bash iptables wireless-tools build-base libpcap-dev libusb-dev linux-headers libnetfilter_queue-dev git

WORKDIR $SRC_DIR
ADD . $SRC_DIR
Expand All @@ -16,8 +16,8 @@ RUN git clone https://github.com/bettercap/caplets /usr/local/share/bettercap/ca

# final stage
FROM alpine
RUN apk add --update ca-certificates
RUN apk add --no-cache --update bash iproute2 libpcap libusb-dev libnetfilter_queue wireless-tools
RUN apk add --no-cache ca-certificates
RUN apk add --no-cache bash iproute2 libpcap libusb-dev libnetfilter_queue wireless-tools
COPY --from=build-env /go/src/github.com/bettercap/bettercap/bettercap /app/
COPY --from=build-env /usr/local/share/bettercap/caplets /app/
WORKDIR /app
Expand Down

0 comments on commit e81f36c

Please sign in to comment.