Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker documentation points to bettercap/bettercap, which is out of date #553

Closed
tedder opened this issue Apr 24, 2019 · 5 comments
Closed

Comments

@tedder
Copy link

tedder commented Apr 24, 2019

Per #107 someone must've uploaded a Docker build to dockerhub's bettercap/bettercap once. It was replaced (in #107) with bettercap/dev. There's no 'stable' build there but at least it isn't 1+year out of date.

The problem is that the documentation points to dockerhub's bettercap/bettercap, not /dev. Putting it here (vs website) because it's really a process issue- do you want to support a stable version? I'd suggest so.

I'm skipping the issue template because this is an odd duck of an issue.

@evilsocket evilsocket transferred this issue from bettercap/bettercap Apr 24, 2019
@evilsocket
Copy link
Member

you know you can send a PR to this repo? :)

@tedder
Copy link
Author

tedder commented Apr 24, 2019

Of course- my concern is the process decision, not the docfix.

@evilsocket
Copy link
Member

to be very, very honest: i am a docker n00b and i had no idea wtf i was doing, i'm basically not using the dockerized image and not updating it neither, so i have no idea what mess i've done on dockerhub 🗡️
I'm very open to (possibly brief) suggestions about best practices and whatnots :D

@tedder
Copy link
Author

tedder commented Apr 24, 2019

Heh. Gotcha. No problem. May as well just use the /dev version and kill the /bettercap version. I can submit a PR for the docs in this repo but you have to delete the bettercap/bettercap container. It should be at this URL:

https://cloud.docker.com/repository/docker/bettercap/bettercap/settings

@evilsocket evilsocket transferred this issue from bettercap/website Apr 24, 2019
@evilsocket
Copy link
Member

aaand i just learned to use docker properly, the release.sh script will now build and push to dockerhub whenever i'll release a new version ... moreover bettercap/bettercap (the stable image) has been updated to v2.23 manually :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants