Lock before suspend to prevent race #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For suspend to work consistently, the screen must be locked before the suspend. Otherwise, occasionally the suspend will occur before the screen locks, resulting in a wakeup to a momentarily unlocked screen.
This patch removes the "
-n
(--nofork
)" flag from the i3lock invocation. i3lock Forking is useful because it allows locking to properly occur before the suspend, as in this patch and as described in the i3lock-color man page:Was there a reason for enabling nofork? If so, this patch can be reworked to fix the problem in another way.