Feat/allow checkers to pass #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to update tests |
btjl
reviewed
May 2, 2024
| const factCheckerCount = totalVoteRequestsCount - errorCount //don't count "error" votes in number of fact checkers, as this will slow the replies unnecessarily. | ||
| const validResponsesCount = responsesCount - errorCount //can remove in future and replace with nonErrorCount | ||
| const factCheckerCount = totalVoteRequestsCount - passCount //don't count "error" votes in number of fact checkers, as this will slow the replies unnecessarily. | ||
| const validResponsesCount = responsesCount - passCount //can remove in future and replace with nonErrorCount |
There was a problem hiding this comment.
Similar to L63, should we include a check? Defaulting to 0
There was a problem hiding this comment.
I think no need actually. cos L63 is the only resolved promise in the promise.all that isn't coming from the async getCount function. The getCount function will definitely return an integer >= 0. So i think its fine.
btjl
approved these changes
May 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues