Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: tobolar <tobolar@users.noreply.github.com>
  • Loading branch information
HansOlsson and tobolar committed Jan 11, 2024
1 parent e872ac3 commit f35bfd9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Modelica/Media/IdealGases/Common/package.mo
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ Temperature T (= " + String(T) + " K) is not in the allowed range
end setState_dTX;

redeclare function extends setSmoothState
"Return thermodynamic state so that it smoothly approximates: if x > 0 then state_a else state_b"
"Return thermodynamic state so that it smoothly approximates: if x > 0 then state_a else state_b"
algorithm
state := ThermodynamicState(p=Media.Common.smoothStep(x, state_a.p, state_b.p, x_small),
T=Media.Common.smoothStep(x, state_a.T, state_b.T, x_small));
Expand Down Expand Up @@ -687,7 +687,7 @@ required from medium model \"" + mediumName + "\".");
end setState_dTX;

redeclare function extends setSmoothState
"Return thermodynamic state so that it smoothly approximates: if x > 0 then state_a else state_b"
"Return thermodynamic state so that it smoothly approximates: if x > 0 then state_a else state_b"
algorithm
state := ThermodynamicState(p=Media.Common.smoothStep(x, state_a.p, state_b.p, x_small),
T=Media.Common.smoothStep(x, state_a.T, state_b.T, x_small),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ model RelTemperatureSensor "Temperature difference sensor"
extends FluidHeatFlow.Interfaces.RelativeSensorBase;
Modelica.Blocks.Interfaces.RealOutput y(unit="K")
"Temperature difference as output signal"
annotation (absoluteValue = false, Placement(transformation(
annotation (absoluteValue = false, Placement(transformation(
origin={0,-110},
extent={{10,-10},{-10,10}},
rotation=90)));
Expand Down
2 changes: 1 addition & 1 deletion ModelicaTest/Electrical/QuasiStatic/Polyphase.mo
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ package Polyphase "Polyphase quasi-static package"
Modelica.Electrical.QuasiStatic.Polyphase.Ideal.Short short(m=m) annotation (Placement(transformation(extent={{-80,20},{-60,40}})));
Modelica.Electrical.QuasiStatic.Polyphase.Ideal.IdealCommutingSwitch idealCommutingSwitch(m=m,
Ron=fill(1E-5, m),
Goff=fill(1E-5, m)) annotation (Placement(transformation(extent={{30,20},{50,40}})));
Goff=fill(1E-5, m)) annotation (Placement(transformation(extent={{30,20},{50,40}})));
Modelica.Electrical.QuasiStatic.Polyphase.Ideal.IdealIntermediateSwitch idealIntermediateSwitch(m=m,
Ron=fill(1E-5, m),
Goff=fill(1E-5, m)) annotation (Placement(transformation(extent={{60,20},{80,40}})));
Expand Down

0 comments on commit f35bfd9

Please sign in to comment.