Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btn-red is almost never a good class name #9

Closed
bcullman opened this issue Jul 10, 2015 · 2 comments
Closed

btn-red is almost never a good class name #9

bcullman opened this issue Jul 10, 2015 · 2 comments

Comments

@bcullman
Copy link

Under the section entitled "Styles", I believe you were trying to point out how to avoid the use of !important, which is reasonable. however, I think using "btn-red" as a style name under a subheading of "Good" may also give the impression that the class name is a good one.

It is preferable to describe the semantic meaning of the button is red (warning? error?) rather than the color, so it can be later altered by the designer (can we make it orange?) without causing a semantic disconect

@bevacqua
Copy link
Owner

Feel free to submit a PR to clarify

@flyingfisch
Copy link
Contributor

Submitted a PR which should fix this issue.

bevacqua added a commit that referenced this issue Oct 23, 2015
Fix #9: gave .btn-red class more semantic meaning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants