Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The DevTools feed should include commits from v8/src/inspector #27

Closed
phistuck opened this issue Nov 24, 2016 · 2 comments
Closed

The DevTools feed should include commits from v8/src/inspector #27

phistuck opened this issue Nov 24, 2016 · 2 comments

Comments

@phistuck
Copy link

https://chromium.googlesource.com/v8/v8/+/master/src/inspector/ includes code that was up until a few months ago in the Chromium/Developer Tools repository. This code affects the backend of the Developer Tools (now shared with NodeJS). I think it should be included in the field as well.

@beverloo
Copy link
Owner

The filter code doesn't discriminate based on the repository. Instead, it looks for certain phrases in the commit's message. Today those phrases are "Dev Tools" and "DevTools".

It looks like the vast majority of changes in that directory use the "[Inspector]" prefix. I'll add that as a keyword too.

@phistuck
Copy link
Author

Gracias. :)

maxbaxfax pushed a commit to maxbaxfax/peter.sh that referenced this issue Jun 2, 2024
Also make the keyword search case insensitive. Fixes beverloo#27
mazl-srlnd pushed a commit to mazl-srlnd/peter.sh that referenced this issue Jun 16, 2024
Also make the keyword search case insensitive. Fixes beverloo#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants