Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json node engine >=0.8 might be incorrect #68

Closed
jspiro opened this issue Dec 16, 2015 · 5 comments
Closed

package.json node engine >=0.8 might be incorrect #68

jspiro opened this issue Dec 16, 2015 · 5 comments

Comments

@jspiro
Copy link

jspiro commented Dec 16, 2015

When you're on an older version of node, say 0.10.40, and you load cson:

node_modules/cson/node_modules/extract-opts/node_modules/typechecker/es6/lib/typechecker.js:29
        for ( let type of types ) {

So one of the subdependencies needs es6. Despite this, it seems like cson works in older nodes, just with an error above.

Not sure what the correct solution is since I'm not the maintainer.

@balupton
Copy link
Member

Hey thanks for this.

It's a warning that shouldn't be outputted, hence why it is not present in 0.12 despite 0.12 not supporting it anyway. Will work anyway.

The fix has already been pushed to the latest typechecker (which now uses the esnextguardian package), the extract-opts package needs to be updated, I'll focus it on my next todo.

Currently having some personal matters to attend to this week, so will aim for next week.

Cheers.

@balupton
Copy link
Member

Changes for this:

  1. https://github.com/bevry/extract-opts needs to be updated for our latest base files and esnextguardian — this is a planned change anyway and will re-add 0.10 support.
  2. For 0.8 support, https://github.com/bevry/typechecker/blob/master/package.json and https://github.com/bevry/esnextguardian/blob/master/package.json need to be changed to node >= 0.8 — whether or not they can still run on node 0.8 is a different question, as it is hard to test on that environment as a lot of dev deps these days don't support that environment. I'm happy dropping 0.8 support for these reasons.

I wish npm actually gave data on their website about which percentage of node version categories (0.8, 0.10, 4, 5) are actually installing your deps.

@balupton
Copy link
Member

/ref #69

balupton added a commit to bevry/base that referenced this issue Jan 15, 2016
@balupton
Copy link
Member

I've updated extract-opts to once again work on node 0.10, and added explicit tests for 0.10 compat

@balupton
Copy link
Member

Will drop 0.10 support. It will be up to the user to include the babel polyfill for environments less than node 0.12. See bevry/base#20 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants