Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: merge echo-element and echo-segment into echo-style #232

Open
5 tasks done
balupton opened this issue Jun 29, 2024 · 3 comments
Open
5 tasks done

Suggestion: merge echo-element and echo-segment into echo-style #232

balupton opened this issue Jun 29, 2024 · 3 comments
Labels
enhancement Improvement or suggestion
Milestone
Share Launch

Comments

@balupton
Copy link
Member

balupton commented Jun 29, 2024 •
edited
Loading

Work has started on this, including the following:

  • enable choose to be themeable
  • support nocolor variants for segments and elements
  • rework targets for better performance now that there is native nocolor support
  • Simplify and improve alias handling, which will improve handling of disable styles

Remaining todos:

  • continuation styling is broken
@balupton
Copy link
Member Author

This is nearly complete. Just need to do the deprecations now. Very happy with the result.

@balupton balupton added the enhancement Improvement or suggestion label Jun 30, 2024
@balupton
Copy link
Member Author

Deprecations complete. Now just tests and help to update.

@balupton
Copy link
Member Author

balupton commented Jul 1, 2024

This is completed locally.

balupton added a commit that referenced this issue Jul 1, 2024
@balupton
echo-style: merge echo-element, echo-segment
2982177 
changes:
- deprecated `echo-element` and `echo-segment`, as they are now supported by `echo-style`
- `echo-style` and `styles.bash` updated for begin/end and color/nocolor styles
- `echo-style` updated to do the minimal writes for performance and simplicity
- `styles.bash` now has the `choose` styles, so `choose` theme can be customised by the user
- `choose` fixed and styled no selection / no items

/close #232
/ref #231 #188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement or suggestion
Milestone
Share Launch
Development

No branches or pull requests
1 participant
@balupton