Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ask: support --default=<value>, close #99 #213

Merged
merged 4 commits into from
Feb 22, 2024
Merged

ask: support --default=<value>, close #99 #213

merged 4 commits into from
Feb 22, 2024

Conversation

balupton
Copy link
Member

No description provided.

@balupton balupton merged commit faf3222 into master Feb 22, 2024
4 of 25 checks passed
@balupton balupton deleted the dev-defaults branch February 22, 2024 03:40
balupton added a commit that referenced this pull request Feb 25, 2024
@balupton
ask: support --default=<value>, close #99 (#213)
1979ed8 
* ask: support editing the default value /ref 6357fac
* ask: as read now supports defaults, redo the confirm flow /ref ddff467
* ask: use cursor rather than alt tty, implement --linger /ref 4d3e6fb
balupton added a commit that referenced this pull request Feb 25, 2024
@balupton
ask: integrate #99 (#213)
8762807 
- implement `--linger`, default to enabled
- fix readline defaults failing when programatic stdin
- fix tests
- fix `echo-clear-lines` not retaining inlines which caused incorrect lines to be cleared
- adapt callers for new defaults and expectations
balupton added a commit that referenced this pull request Feb 25, 2024
@balupton
ask: support --default=<value>, close #99 (#213)
975a387 
* ask: support editing the default value /ref 6357fac
* ask: as read now supports defaults, redo the confirm flow /ref ddff467
* ask: use cursor rather than alt tty, implement --linger /ref 4d3e6fb
balupton added a commit that referenced this pull request Feb 25, 2024
@balupton
ask: integrate #99 (#213)
ced79b8 
- implement `--linger`, default to enabled
- fix readline defaults failing when programatic stdin
- fix tests
- fix `echo-clear-lines` not retaining inlines which caused incorrect lines to be cleared
- adapt callers for new defaults and expectations
balupton added a commit that referenced this pull request Feb 25, 2024
@balupton
ask: support --default=<value>, close #99 (#213)
89b386e 
* ask: support editing the default value /ref 6357fac
* ask: as read now supports defaults, redo the confirm flow /ref ddff467
* ask: use cursor rather than alt tty, implement --linger /ref 4d3e6fb
balupton added a commit that referenced this pull request Feb 25, 2024
@balupton
ask: integrate #99 (#213)
ffe2193 
- implement `--linger`, default to enabled
- fix readline defaults failing when programatic stdin
- fix tests
- fix `echo-clear-lines` not retaining inlines which caused incorrect lines to be cleared
- adapt callers for new defaults and expectations
@balupton balupton mentioned this pull request Jun 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@balupton