Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins key required? #6

Closed
chriskrycho opened this issue Jun 11, 2016 · 5 comments
Closed

Plugins key required? #6

chriskrycho opened this issue Jun 11, 2016 · 5 comments

Comments

@chriskrycho
Copy link

It appears that the plugins key is required if you need to use e.g the xml plugin parser. This is not documented publicly.
@balupton
Copy link
Member

Will be a regression in the last minor release which rewrote from coffeescript to JavaScript. Will look into it in the coming days.

@balupton
Copy link
Member

PR would be welcome if you wish!

@balupton
Copy link
Member

looking into this today

@chriskrycho
Copy link
Author

chriskrycho commented Jun 13, 2016 via email

@balupton
Copy link
Member

balupton commented Jun 13, 2016 •
edited
Loading

no worries, the onus really was on me - for your appetite, this was the fix https://github.com/bevry/feedr/commit/4e8a5a548aaa9751d198450f8afbab8eaf847391#diff-c60c67bd505d9618ebf77a7f130903d0L173 the last minor release had this https://github.com/bevry/feedr/blob/v2.12.0/src/lib/feedr.coffee#L192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@balupton @chriskrycho