Add '-a' to ifconfig command #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI fails as it does not yield mac addresses with ifconfig command. Tests passing on my local node 0.12.x install ubuntu 15. |
|
Good idea thanks. Added to the merge queue. |
|
Released to v1.2.1. Sorry for the delay. The last 24 months have been hard on me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default behavior of ifconfig is to only show interfaces that are up. This yields inconsistent results on systems with interfaces that are hot plugged. Adding -a to ifconfig returns all interfaces, even down. For ip link, this is not an issue as it will show all interfaces by default.