Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken web site links #307

Merged
merged 1 commit into from May 25, 2017
Merged

Fix broken web site links #307

merged 1 commit into from May 25, 2017

Conversation

denisdefreyne
Copy link
Contributor

No description provided.

@denisdefreyne denisdefreyne changed the title Remove CMX.js web site (no longer exists) Fix broken web site links May 25, 2017
@denisdefreyne denisdefreyne force-pushed the fix-cmxjs branch 7 times, most recently from 349b7a1 to 6cb21c0 Compare May 25, 2017 16:44
@denisdefreyne
Fix broken links
5088936 
* Remove CMX.js web site (no longer exists)
* Remove jagss web site (no longer exists)
* Remove Olai (no longer exists, no web site/github)
* Update JR web site
* Update staticmatic2 GitHub repo
* Update trofaf GitHub repo
* Update webgen GitHub repo
* Update woods GitHub repo
* Remove Scriptogram (no longer exists)
@denisdefreyne
Copy link
Contributor Author

Now fails with

TypeError: Cannot read property 'message' of null

:|

@balupton
Copy link
Member

yeah, due to rate limits being hit

I've added the needed env vars to the travis setup, but seems they won't apply on the PR

I've added you to the SSGs team, so you have write access to this repo, feel free to merge, as the merge should work - if it doesn't, then happy for you to work off master, and to keep up the great work uninhibited!

@denisdefreyne denisdefreyne merged commit dc2944a into bevry:master May 25, 2017
@denisdefreyne denisdefreyne deleted the fix-cmxjs branch May 25, 2017 17:12
@balupton
Copy link
Member

balupton commented May 25, 2017 •
edited

from the merge commit build https://travis-ci.org/bevry/staticsitegenerators-list/builds/236086091

Comparison Error:
AssertionError: there was automated data written into the manual listing, this has been removed, run the tests again
    at equal (/home/travis/build/bevry/staticsitegenerators-list/node_modules/assert-helpers/source/index.js:171:10)
    at EventEmitterGrouped.<anonymous> (/home/travis/build/bevry/staticsitegenerators-list/test.js:105:6)
    at ambi (/home/travis/build/bevry/staticsitegenerators-list/node_modules/ambi/source/index.js:91:18)
    at Domain.fireMethod (/home/travis/build/bevry/staticsitegenerators-list/node_modules/taskgroup/source/lib/task.js:519:5)
    at Domain.run (domain.js:221:14)
    at EventEmitterGrouped.fire (/home/travis/build/bevry/staticsitegenerators-list/node_modules/taskgroup/source/lib/task.js:537:15)
    at tryOnImmediate (timers.js:645:5)
    at processImmediate [as _immediateCallback] (timers.js:617:5)
Comparison Diff:

not a useful comparison diff there, we should probably output specifically which fields for which entries it is complaining about, rather than doing a diff

that said, all it needs is a local run, and commit of the changes, and a push up

@balupton
Copy link
Member

do you want to do the local build, commit, and push?

@balupton balupton mentioned this pull request May 25, 2017
Open
@denisdefreyne
Copy link
Contributor Author

I’ll take care of it!

@denisdefreyne
Copy link
Contributor Author

Back to green!

@balupton
Copy link
Member

balupton commented May 25, 2017 •
edited

@ddfreyne and auto-deployed it seems! great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@denisdefreyne @balupton