Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhotoEditorViewController leaking memory via retain cycle #41

Open
jonchui opened this issue Aug 11, 2018 · 2 comments
Open

PhotoEditorViewController leaking memory via retain cycle #41

jonchui opened this issue Aug 11, 2018 · 2 comments

Comments

@jonchui
Copy link

jonchui commented Aug 11, 2018

When you push the PhotoEditorViewController and finish, you can see in the Xcode memory guage that a huge amount of heap memory isn't getting released. Most likely due to the image.

Here i've edited 5 different photos, going back to the main screen each time (which should reset the heap) . You can see every time the heap increases but does not go down after popping:

image

@jonchui
Copy link
Author

jonchui commented Aug 11, 2018

After fixing those initial leaks (cause by retain cycles w/ non-weak delegates), i found some more:

image

Here's a gif of my run:
http://recordit.co/UISvPsprVd.gif

jonchui added a commit to jonchui/photo-editor that referenced this issue Aug 11, 2018
@jonchui
Copy link
Author

jonchui commented Aug 11, 2018

FYI: i opened PR #42 that fixes it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant