Add custom atom.xml template to hide public draft news articles
#1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doup
approved these changes
May 14, 2024
There was a problem hiding this comment.
OK, I've poked around with Zola trying to find a workaround[0] but it looks like until this issue in Zola this is the best option.
Approved 👍.
0: Zola docs state Only pages with a date will be available.… but I couldn't make posts disappear while keeping the public draft preview. There is a zola build --drafts flag, but it comes with it's own issues.
doup
reviewed
May 14, 2024
| <updated>{{ last_updated | date(format="%+") }}</updated> | ||
| <id>{{ feed_url | safe }}</id> | ||
| {%- for page in pages %} | ||
| {%- if not page.extra.public_draft %} |
There was a problem hiding this comment.
Note: For the next reviewer, this PR just adds lines 23 and 53. Original file.
IceSentry
approved these changes
May 14, 2024
TrialDragon
added
the
S-Ready-For-Final-Review
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1103
Adds an
atom.xmltemplate file that hides pages which are public draft from the news feeds, primary line of code relevant beingLine 23. Note, this doesn't modify the last updated date, so that is still tracking the latest file regardless of public draft, but that is a minor issue that I think is irrelevant to our situation so far.