New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak header #609
Tweak header #609
Conversation
With the extra space, the full logo can be shown on mobile (changed in 3099d51): Btw, I've looked what the current recommendation for minimum screen size is, and it looks like it's 360px (few years ago it was 320px). The screenshot above is at 360px; the video from the description also shows how it behaves at 360px. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tried it and everything looks good at every size I tried.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! I think I might prefer putting the "getting started" button in the header on mobile over adding "getting started" to the collapsed menu. But I'll happily merge this as-is.
But… in exchange of what? We can't have all these: full bevy logo, getting started, donate (with/without ❤️) & GitHub logo. I think the options are:
|
Ahh I didn't know we didn't have the space for it. Lets leave it as-is for now :) |
tablet-landscape
breakpoint size, so we don't push mobile design to desktop usersbevy-tweak-header.mp4