Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak header #609

Merged
merged 10 commits into from Mar 16, 2023
Merged

Tweak header #609

merged 10 commits into from Mar 16, 2023

Conversation

doup
Copy link
Contributor

@doup doup commented Mar 16, 2023

  • Remove "Get Started" from header
    • Move it to home page
    • Add "Getting Started" entry in mobile menu
  • Tweak GitHub link in header:
    • Remove weird space to the right
    • Make it a tiny bit smaller
  • Tweak desktop header menu font-size: make it a tiny bit smaller so it breaths more in "Migration Guide"/"Supporting Bevy" pages
  • Revert tablet-landscape breakpoint size, so we don't push mobile design to desktop users
bevy-tweak-header.mp4

@doup
Copy link
Contributor Author

doup commented Mar 16, 2023

With the extra space, the full logo can be shown on mobile (changed in 3099d51):
image

Btw, I've looked what the current recommendation for minimum screen size is, and it looks like it's 360px (few years ago it was 320px). The screenshot above is at 360px; the video from the description also shows how it behaves at 360px.

Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tried it and everything looks good at every size I tried.

Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! I think I might prefer putting the "getting started" button in the header on mobile over adding "getting started" to the collapsed menu. But I'll happily merge this as-is.

@cart cart added this pull request to the merge queue Mar 16, 2023
@doup
Copy link
Contributor Author

doup commented Mar 16, 2023

But… in exchange of what? We can't have all these: full bevy logo, getting started, donate (with/without ❤️) & GitHub logo. I think the options are:

  • Full logo + (getting started or donate) + GitHub
  • Reduced logo + getting started + donate might

Merged via the queue into bevyengine:main with commit a9709d1 Mar 16, 2023
6 checks passed
@cart
Copy link
Member

cart commented Mar 16, 2023

Ahh I didn't know we didn't have the space for it. Lets leave it as-is for now :)

@doup doup deleted the tweak-header branch March 16, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants